Needs correction on VPC NG Network Load Balancer CLI document #7 #8
Conversation
vpc-cli-reference.md
Outdated
| @@ -1284,22 +1284,22 @@ ibmcloud is load-balancer LOAD_BALANCER [--vpc VPC] [--output JSON] [-q, --quiet | |||
| Create a load balancer. | |||
|
|
|||
| ``` | |||
| ibmcloud is load-balancer-create LOAD_BALANCER_NAME LOAD_BALANCER_TYPE (--subnet SUBNET1 --subnet SUBNET2 ... [--vpc VPC]) [--family application | network] [--route-mode false | true] [--sg SG] [--logging-datapath-active false | true] [--resource-group-id RESOURCE_GROUP_ID | --resource-group-name RESOURCE_GROUP_NAME] [--output JSON] [-q, --quiet] | |||
| ibmcloud is load-balancer-create LOAD_BALANCER_NAME LOAD_BALANCER_TYPE (--subnet SUBNET1 ... [--vpc VPC]) [--family network] [--route-mode false | true] [--sg SG] [--logging-datapath-active false | true] [--resource-group-id RESOURCE_GROUP_ID | --resource-group-name RESOURCE_GROUP_NAME] [--output JSON] [-q, --quiet] | |||
There was a problem hiding this comment.
| ibmcloud is load-balancer-create LOAD_BALANCER_NAME LOAD_BALANCER_TYPE (--subnet SUBNET1 ... [--vpc VPC]) [--family network] [--route-mode false | true] [--sg SG] [--logging-datapath-active false | true] [--resource-group-id RESOURCE_GROUP_ID | --resource-group-name RESOURCE_GROUP_NAME] [--output JSON] [-q, --quiet] | |
| ibmcloud is load-balancer-create LOAD_BALANCER_NAME LOAD_BALANCER_TYPE (--subnet SUBNET1 [--vpc VPC]) [--family network] [--route-mode false | true] [--sg SG] [--logging-datapath-active false | true] [--resource-group-id RESOURCE_GROUP_ID | --resource-group-name RESOURCE_GROUP_NAME] [--output JSON] [-q, --quiet] |
There was a problem hiding this comment.
@KumarGanesanIBM above changes are done.
… on VPC NG Network Load Balancer CLI document ibm-cloud-docs#7 ibm-cloud-docs#8
|
@mitchell Could you please review this request. |
|
LGTM Sending to @sterling for review |
|
I don't think you want me to review this |
| @@ -1451,18 +1441,11 @@ Create a load balancer listener with udp protocol. | |||
|
|
|||
| - **LOAD_BALANCER**: ID or name of the load balancer. | |||
| - **--vpc**: ID or name of the VPC. It is only required to specify the unique resource by name inside this VPC. | |||
| - **--protocol**: The listener protocol. Load balancers in the application family support tcp, http, and https. Load balancers in the network family support tcp and udp. | |||
There was a problem hiding this comment.
Use asterisks (** **) around the values to make the protocol options bold. I see this in multiple places.
There was a problem hiding this comment.
I do not have the proper permission to edit or create a PR in the repo. Otherwise, Kumar approved. All good.
There was a problem hiding this comment.
@austinmama granted the permission to repo for edit. meanwhile updating protocol with asterisks.
|
@sshankaramurthy I understand that @jmilst is handling. In the future, please open PRs against the staging server here: https://github.ibm.com/cloud-docs/vpc-infrastructure-cli-plugin/blob/draft/vpc-cli-reference.md |
Except these two below updated the all the commands as per the issue created.
ibmcloud is load-balancer-pool-create santhosh-test-pool4 santhosh-test-nlb round_robin tcp 20 2 5 --health-monitor-url c4780015-jp-tok.lb.appdomain.cloud --health-monitor-port 4001
bmcloud is load-balancer-pool-update 72251a2e-d6c5-42b4-97b0-b5f8e8d1f479 72b27b5c-f4b0-48bb-b954-5becc7c1dcb3 --health-monitor-url / --health-monitor-port 4001