Generate secret key: Remove global mfa check #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user generates secret key, currently there is a check to see if
the global mfa is enabled. And only if it is enabled, secret key
generation is allowed for the user.
This commit removes the check, and enables users to generate secret key
even if the global mfa is disabled.
Tested By:
'''
POST https://${bmc}/redfish/v1/AccountService/Accounts/<>/Actions/ManagerAccount.GenerateSecretKey
'''
Signed-off-by: Asmitha Karunanithi <[email protected]>
raviteja-b
approved these changes
Jan 13, 2025
abhilashraju
approved these changes
Jan 13, 2025
gtmills
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user generates secret key, currently there is a check to see if the global mfa is enabled. And only if it is enabled, secret key generation is allowed for the user.
This commit removes the check, and enables users to generate secret key even if the global mfa is disabled.
Upstream: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/74667
Tested By:
'''
POST https://${bmc}/redfish/v1/AccountService/Accounts/<>/Actions/ManagerAccount.GenerateSecretKey
'''