Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hw-Isolation: Deconfiguration type for DIMMs #1126

Open
wants to merge 1 commit into
base: 1110
Choose a base branch
from

Conversation

deepakala-k
Copy link
Contributor

This change should have been part of
https://github.com/ibm-openbmc/bmcweb/pull/953/commits/7d6dd2c6b632d24752eba7870343ed9c790d638e

Here is the original commit.
https://github.com/ibm-openbmc/bmcweb/pull/171/files

Due to this missing change, the deconfiguration type is not displayed in the GUI. After including this change, here is the redfish output.


curl -k -H "X-Auth-Token: $bmc_token" -XGET https://${BMC_IP}/redfish/v1/Systems/system/Memory/dimm1
{
  "/Status/Conditions/0/Severity": "OK",
  "@odata.id": "/redfish/v1/Systems/system/Memory/dimm1",
  "@odata.type": "#Memory.v1_12_0.Memory",
  "AllowedSpeedsMHz": [],
  "BaseModuleType": "RDIMM",
  "BusWidthBits": 0,
  "CapacityMiB": 32768,
  "DataWidthBits": 0,
  "Enabled": false,
  "ErrorCorrection": "NoECC",
  "FirmwareRevision": "0",
  "Id": "dimm1",
  "Location": {
    "PartLocation": {
      "ServiceLabel": "U78DB.ND0.WZS000G-P0-C13"
    }
  },
  "LocationIndicatorActive": false,
  "Manufacturer": "",
  "Model": "327A",
  "Name": "Memory module 1",
  "OperatingSpeedMhz": 0,
  "PartNumber": "78P6574",
  "RankCount": 0,
  "SerialNumber": "YH30MS03T038",
  "SparePartNumber": "78P6574",
  "Status": {
    "Conditions": [
      {
        "Message": "The reason for the resource isolation: Manual",
        "MessageArgs": [
          "Manual"
        ],
        "MessageId": "OpenBMC.0.2.HardwareIsolationReason",
        "Timestamp": "2025-01-21T10:27:55+00:00"
      }
    ],
    "Health": "Critical",
    "State": "Disabled"
  }
}

@deepakala-k deepakala-k requested a review from baemyung January 21, 2025 12:23
@deepakala-k deepakala-k force-pushed the fix_dimm_deconfig_reason branch from 51713d0 to e4a0a06 Compare January 21, 2025 13:54
This change should have been part of
```https://github.com/ibm-openbmc/bmcweb/pull/953/commits/7d6dd2c6b632d24752eba7870343ed9c790d638e```

Here is the original commit.
```https://github.com/ibm-openbmc/bmcweb/pull/171/files```

Due to this missing change, the deconfiguration type is not displayed in
the GUI. After including this change, here is the redfish output.

```

curl -k -H "X-Auth-Token: $bmc_token" -XGET https://${BMC_IP}/redfish/v1/Systems/system/Memory/dimm1
{
  "/Status/Conditions/0/Severity": "OK",
  "@odata.id": "/redfish/v1/Systems/system/Memory/dimm1",
  "@odata.type": "#Memory.v1_12_0.Memory",
  "AllowedSpeedsMHz": [],
  "BaseModuleType": "RDIMM",
  "BusWidthBits": 0,
  "CapacityMiB": 32768,
  "DataWidthBits": 0,
  "Enabled": false,
  "ErrorCorrection": "NoECC",
  "FirmwareRevision": "0",
  "Id": "dimm1",
  "Location": {
    "PartLocation": {
      "ServiceLabel": "U78DB.ND0.WZS000G-P0-C13"
    }
  },
  "LocationIndicatorActive": false,
  "Manufacturer": "",
  "Model": "327A",
  "Name": "Memory module 1",
  "OperatingSpeedMhz": 0,
  "PartNumber": "78P6574",
  "RankCount": 0,
  "SerialNumber": "YH30MS03T038",
  "SparePartNumber": "78P6574",
  "Status": {
    "Conditions": [
      {
        "Message": "The reason for the resource isolation: Manual",
        "MessageArgs": [
          "Manual"
        ],
        "MessageId": "OpenBMC.0.2.HardwareIsolationReason",
        "Timestamp": "2025-01-21T10:27:55+00:00"
      }
    ],
    "Health": "Critical",
    "State": "Disabled"
  }
}

```

Signed-off-by: deepakalak <[email protected]>
@deepakala-k deepakala-k force-pushed the fix_dimm_deconfig_reason branch from e4a0a06 to 1fed726 Compare January 21, 2025 16:54
Copy link
Contributor

@baemyung baemyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me (and also comparing with 1060).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants