Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for asynchronous file transfer #404

Open
wants to merge 19 commits into
base: 1060
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f31f74d
Dummy PR: Non blocking socket changes
Patel-Kamalkumar Apr 5, 2023
35aeb4a
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar Apr 17, 2023
ba2a578
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar May 4, 2023
a988aeb
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar May 4, 2023
1832f37
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar May 8, 2023
3434379
Adding Support of Nonblocking socket
Patel-Kamalkumar May 9, 2023
81944ba
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar May 16, 2023
7dde80c
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar May 22, 2023
b6aca03
Adding support for asynchronous file transfer
Patel-Kamalkumar May 25, 2023
5cf6317
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar Aug 1, 2023
7d15686
Throw Marker Lid validate error (#446)
sagisin Aug 21, 2023
5f426bd
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar Aug 1, 2023
6ff41f6
Moving fetch activation property (#449)
sagisin Aug 25, 2023
924e026
pdr: Missing nvme slot entries in the json (#447)
Pavithrab7 Aug 25, 2023
af6dea7
PLDM: 5 sec timeout for dbus calls without reply (#444)
vkaverap Aug 28, 2023
9633dd8
oem-ibm: Call PEL API when host drops event log (#461)
spinler Sep 15, 2023
d7e0cb9
PLDM: LG2 migration for missed out traces (#466)
riyadixitagra Oct 4, 2023
07cd485
Adding support for asynchronous file transfer
Patel-Kamalkumar Aug 27, 2023
d576b33
Merge branch '1050' of github.com:Patel-Kamalkumar/pldm into AIO
Patel-Kamalkumar Oct 6, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moving fetch activation property (#449)
This commit adds change to move the fetching of activation
property inside the inband code update path. As it is a no-op
for out of band updates.

Signed-off-by: Sagar Srinivas <sagar.srinivas@ibm.com>
  • Loading branch information
sagisin authored Aug 25, 2023
commit 6ff41f64420a677d71878ddd1ce9d7f0d94263cf
16 changes: 8 additions & 8 deletions oem/ibm/libpldmresponder/inband_code_update.cpp
Original file line number Diff line number Diff line change
@@ -335,15 +335,15 @@ void CodeUpdate::setVersions()

try
{
auto propVal =
pldm::utils::DBusHandler().getDbusPropertyVariant(
imageObjPath, "Activation", imageInterface);
const auto& activation = std::get<std::string>(propVal);

if (activation ==
"xyz.openbmc_project.Software.Activation.Activations.Invalid")
if (isCodeUpdateInProgress())
{
if (isCodeUpdateInProgress())
auto propVal =
pldm::utils::DBusHandler().getDbusPropertyVariant(
imageObjPath, "Activation", imageInterface);
const auto& activation = std::get<std::string>(propVal);

if (activation ==
"xyz.openbmc_project.Software.Activation.Activations.Invalid")
{
error(
"InbandCodeUpdate Failed: Received Invalid Signal, Sending Error on End update sensor event to PHYP");