Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed event id issue on Hardware deconfiguration page #347

Closed

Conversation

vedangimittal
Copy link

- Event id now getting updated for deconfigured core on Hardeware deconfiguration page
- Defect: https://jazz07.rchland.ibm.com:13443/jazz/web/projects/CSSD#action=com.ibm.team.workitem.viewWorkItem&id=670225

Signed-off-by: Vedangi Mittal <[email protected]>
@@ -50,7 +50,7 @@ const HardwareDeconfigurationStore = {
if (Array.isArray(messageArgsArray) && messageArgsArray.length) {
msgArgs = messageArgsArray[0];
}
const logEntry = conditionsArray[0].LogEntry;
const logEntry = data['/Status/Conditions/0/LogEntry'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is difference in change that would fix this issue...
The new change is accessing the same path....

@vedangimittal
Copy link
Author

Previously, the value for 'Event Id' in the code was being accessed from this redfish key - Status.Conditions.LogEntry, which was undefined because there is no such parameter as 'LogEntry' under Status.Contiditions

Screenshot 2025-01-17 at 5 03 04 PM Screenshot 2025-01-17 at 5 02 57 PM

That's why in the current Redfish, the 'Event Id' value needs to be fetched from the key - '/Status/Conditions/0/LogEntry'
That is the only change made in the code

Screenshot 2025-01-17 at 5 11 32 PM Screenshot 2025-01-17 at 5 11 36 PM

@Nikhil-Ashoka
Copy link
Collaborator

@vedangimittal, Which all releases this change is applicable?

@deepakala-k
Copy link

Please abandon this fix. It will break the earlier version. The redfish output is wrong. Just identified the issue and fixed it. Will raise a PR and provide a link shortly. @vedangimittal please close this PR.

@deepakala-k
Copy link

This is the correct and the expected output

curl -k -H "X-Auth-Token: $bmc_token" -XGET https://${BMC_IP}/redfish/v1/Systems/system/Processors/dcm0-cpu0/SubProcessors/core2
{
  "@odata.id": "/redfish/v1/Systems/system/Processors/dcm0-cpu0/SubProcessors/core2",
  "@odata.type": "#Processor.v1_18_0.Processor",
  "Enabled": false,
  "Id": "core2",
  "Name": "core2",
  "Status": {
    "Conditions": [
      {
        "LogEntry": {
          "@odata.id": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/492"
        },
        "Message": "The reason for the resource isolation: Predictive",
        "MessageArgs": [
          "Predictive"
        ],
        "MessageId": "OpenBMC.0.2.HardwareIsolationReason",
        "Severity": "Warning",
        "Timestamp": "2025-01-27T17:01:53+00:00"
      }
    ],
    "Health": "Critical",
    "State": "Disabled"
  }
}

@vedangimittal
Copy link
Author

Will close the PR, since its a backend issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants