Use the system zlib on platforms other than Windows #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins compile aix,zlinux jdk8 |
|
AIX |
|
The PR build is https://openj9-jenkins.osuosl.org/job/PullRequest-OpenJDK8/93/ |
pshipton
changed the title
keithc-ca
reviewed
Sep 12, 2023
keithc-ca
reviewed
Sep 12, 2023
This makes jdk8 consistent with jdk11. Issue eclipse-openj9/openj9#18127 Signed-off-by: Peter Shipton <[email protected]>
pshipton
changed the title
keithc-ca
approved these changes
Sep 13, 2023
|
Jenkins compile xlinux,win32 jdk8 |
|
In https://openj9-jenkins.osuosl.org/job/Build_JDK8_x86-32_windows_Personal/737/consoleText: In https://openj9-jenkins.osuosl.org/job/Build_JDK8_x86-64_linux_Personal/462/consoleText: |
This was referenced Sep 14, 2023
keithc-ca
added a commit
to keithc-ca/openj9-openjdk8
that referenced
this pull request
Sep 18, 2023
With the recent preference for --with-zlib=system (see ibmruntimes#692), we need to back-port * 8140223: fix the build with a toolchain with a linker defaulting to ld --as-needed I'm not sure why builds succeed on RHEL, but they fail on Ubuntu. Signed-off-by: Keith W. Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes jdk8 consistent with jdk11.
Closes eclipse-openj9/openj9#18127