Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include quest tile in index.rst #497

Merged
merged 26 commits into from
Jan 9, 2025
Merged

include quest tile in index.rst #497

merged 26 commits into from
Jan 9, 2025

Conversation

RomiP
Copy link
Contributor

@RomiP RomiP commented Jan 24, 2024

No description provided.

Copy link

github-actions bot commented Jan 24, 2024

Binder 👈 Launch a binder notebook on this branch for commit b8b5f6c

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit b99fa18

Binder 👈 Launch a binder notebook on this branch for commit b3399fe

Binder 👈 Launch a binder notebook on this branch for commit 30fc2c8

Binder 👈 Launch a binder notebook on this branch for commit f7df79c

Binder 👈 Launch a binder notebook on this branch for commit dbf3ecf

Binder 👈 Launch a binder notebook on this branch for commit 791c1c9

Binder 👈 Launch a binder notebook on this branch for commit df3cc5d

Binder 👈 Launch a binder notebook on this branch for commit ee8cc41

Binder 👈 Launch a binder notebook on this branch for commit 85f9f03

Binder 👈 Launch a binder notebook on this branch for commit 1159114

Binder 👈 Launch a binder notebook on this branch for commit a1412b3

Binder 👈 Launch a binder notebook on this branch for commit 2be3fe2

Binder 👈 Launch a binder notebook on this branch for commit 6c1bdbd

Binder 👈 Launch a binder notebook on this branch for commit f251032

Binder 👈 Launch a binder notebook on this branch for commit 2d058b9

Binder 👈 Launch a binder notebook on this branch for commit ad6179b

Binder 👈 Launch a binder notebook on this branch for commit b71b714

Binder 👈 Launch a binder notebook on this branch for commit 74c3feb

Binder 👈 Launch a binder notebook on this branch for commit c441b9f

Binder 👈 Launch a binder notebook on this branch for commit 292857f

Binder 👈 Launch a binder notebook on this branch for commit 2923a52

Binder 👈 Launch a binder notebook on this branch for commit 694fc5a

Binder 👈 Launch a binder notebook on this branch for commit d7b1bd8

Binder 👈 Launch a binder notebook on this branch for commit 9ebda6d

Binder 👈 Launch a binder notebook on this branch for commit 44a5209

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (7605002) to head (44a5209).
Report is 1 commits behind head on development.

❗ There is a different number of reports uploaded between BASE (7605002) and HEAD (44a5209). Click for more details.

HEAD has 5 uploads less than BASE
Flag BASE (7605002) HEAD (44a5209)
7 2
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #497      +/-   ##
===============================================
- Coverage        71.85%   66.77%   -5.08%     
===============================================
  Files               38       36       -2     
  Lines             3137     3079      -58     
  Branches           426      426              
===============================================
- Hits              2254     2056     -198     
- Misses             774      936     +162     
+ Partials           109       87      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JessicaS11 JessicaS11 mentioned this pull request Mar 27, 2024
6 tasks
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
doc/source/index.rst Outdated Show resolved Hide resolved
@JessicaS11
Copy link
Member

I think there might be something funny going on with internal circular references for the PR docs. It's building without claiming a bad link or ref, and the link is used elsewhere in the docs with no issues. I'm wondering if we ought to consider merging with a plan to find and add a fix if an actual build doesn't work...

Comment on lines 77 to 80
.. link-button:: `QUEST_Finding_Argo_IS2_data <https://icepyx.readthedocs.io/en/latest/example_notebooks/QUEST_argo_data_access.html>`_
:type: url
:text: Start your QUEST!
:classes: stretched-link btn-outline-primary btn-block
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. link-button:: `QUEST_Finding_Argo_IS2_data <https://icepyx.readthedocs.io/en/latest/example_notebooks/QUEST_argo_data_access.html>`_
:type: url
:text: Start your QUEST!
:classes: stretched-link btn-outline-primary btn-block
.. button-ref:: /example_notebooks/QUEST_argo_data_access.ipynb
:class: stretched-link btn-outline-primary btn-block
Start your QUEST!

sphinx-panels (dead project) is replaced by sphinx-design on main. Minor changes required.

I'm not sure if the link will work exactly as written, but what I'm trying to do is replace an absolute URL with generating a URL from a ref.

@JessicaS11 JessicaS11 marked this pull request as ready for review January 9, 2025 21:00
@JessicaS11 JessicaS11 merged commit 4eb7aaf into development Jan 9, 2025
8 checks passed
@JessicaS11 JessicaS11 deleted the quest_tile branch January 9, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants