Making shear and P wave speed user defined quantities for seismic for… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveerara
force-pushed
the
seismic_force_edit
branch
from
1d269ff to
43c5ae0
Compare
|
@sveerara this looks good, but you also need to input the density of the underlying bedrock (apart from the S and P wave velocities) and use that density in the computation of the shear forces and the damper properties for the nonreflecting boundary. |
cbolisetti
reviewed
Dec 7, 2018
cbolisetti
reviewed
Dec 7, 2018
…ce and non reflecting BC idaholab#183
sveerara
force-pushed
the
seismic_force_edit
branch
from
43c5ae0 to
4fe53fb
Compare
|
@cbolisetti, thanks for reviewing the PR. I have addressed your comments. |
cbolisetti
approved these changes
Dec 10, 2018
|
@aeslaughter, can you please merge this PR? |
|
Sorry about not merging this sooner, I stopped paying attention because you assigned @cbolisetti. FYI, if your PR is approved by someone else you can merge it yourself. |
|
Thanks @aeslaughter. That's good to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ce and non reflecting BC #183