-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Physics for linear FV + mixture model #29614
Draft
GiudGiud
wants to merge
18
commits into
idaholab:next
Choose a base branch
from
GiudGiud:PR_linear_twophase
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_linear_twophase
branch
2 times, most recently
from
December 24, 2024 23:54
8248e8f
to
c7c56d2
Compare
Job Documentation, step Docs: sync website on 3753516 wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_linear_twophase
branch
2 times, most recently
from
February 1, 2025 06:41
4586129
to
24c54d3
Compare
Consolidate WCNS and INS time derivatives kernel addition routines
Make setup safer for WCNSFV physics as well refs idaholab#29175
…tween linear and nonlinear implementations
GiudGiud
force-pushed
the
PR_linear_twophase
branch
from
February 1, 2025 06:42
24c54d3
to
f8dc1b6
Compare
Currently a steady solve with only velocity-pressure, not converging. Try transient WIP
…ctor material properties ( = piecewisebyblock lambda functors) can work Add an assert for having a flow physics
GiudGiud
force-pushed
the
PR_linear_twophase
branch
from
February 1, 2025 19:28
63f46dd
to
3753516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #29177 and maybe #29516 to try out transients (or some other way to get a converged solution)
One difficulty is likely that the two phase equation needs to be an "active" scalar, not a passive one, and be solved inside the pressure-velocity-energy picard iteration.
I added code for that. I ll revisit this PR once the prereqs are merged