Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Explain that references don't respect the underscore convention #148

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

tordans
Copy link
Collaborator

@tordans tordans commented Apr 28, 2024

No description provided.

@tordans
Copy link
Collaborator Author

tordans commented Dec 25, 2024

@tyrasd +1 to merge this or something similar so issues like openstreetmap/id-tagging-schema#1415 (comment) don't have to be researched …

Copy link
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relevant code:

schema-builder/lib/build.js

Lines 296 to 300 in 54c2a7d

function stripLeadingUnderscores(str) {
return str.split('/')
.map(s => s.replace(/^_/,''))
.join('/');
}

@tordans tordans merged commit cc210b7 into ideditor:main Dec 26, 2024
1 check passed
@tordans tordans deleted the patch-9 branch December 26, 2024 05:35
@tordans
Copy link
Collaborator Author

tordans commented Dec 26, 2024

I see that I have merge permissions here for my own PRs and I am using this power now to merge this, given that I already created two PRs for the same thin apparently and had to research it again yesterday …

The PR was approved and it is only a documentation change so I think that is OK two work around the rules we set ourselves in the id-taggign-schema repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants