Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update debug info being shown for tiles #9419

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ihhub
Copy link
Owner

@ihhub ihhub commented Jan 6, 2025

This is to help in debugging and understanding of passability rules.

Also fix the number of monsters not being shown for some of Adventure Map dwellings.

Also fix the number of monsters not being shown for some of Adventure Map dwellings.
@ihhub ihhub added the improvement New feature, request or improvement label Jan 6, 2025
@ihhub ihhub added this to the 1.1.6 milestone Jan 6, 2025
@ihhub ihhub self-assigned this Jan 6, 2025
@ihhub ihhub marked this pull request as draft January 7, 2025 00:22
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
26.2% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@ihhub ihhub marked this pull request as ready for review January 9, 2025 14:43
os << "!!! INVALID !!! layer type : " << static_cast<int>( part.layerType ) << " - " << getObjectLayerName( part.layerType ) << std::endl;
}

os << "is shadow : " << ( isObjectPartShadow( part ) ? "yes" : "no" ) << std::endl;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ihhub I have an impression that colons in the changed code are not aligned in regard to the colons in the old code, are they?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants