Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dialog pop up when pressing standing horse #9486

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zenseii
Copy link
Collaborator

@zenseii zenseii commented Jan 24, 2025

This PR is a suggested fix/compromise and works as a draft to test. More polish needs to be done before it can be merged.
fix #9474 (proposal)

This gives feedback when pressing and has the small additional bonus of helping completely new players understand why the hero can't move anymore (I've seen and heard about impatient gamers quit the game after this).

fheroes2.engine.version_.1.1.5.2025-01-24.20-46-02.mp4

The current dialog:
image

This gives feedback when pressing and has the small additional bonus of helping completely new players understand why the hero can't move anymore (I've seen and heard about impatient gamers quit the game after this).
@zenseii zenseii added improvement New feature, request or improvement ui UI/GUI related stuff labels Jan 24, 2025
@zenseii zenseii added this to the 1.1.6 milestone Jan 24, 2025
@Branikolog
Copy link
Collaborator

Hi, @zenseii !

It's a nice hint for the new players, to explain the mechanics of replenishing hero's movement points. The new dialog also shows some feedback while clicking on the new "standing" state button. 👍

I suggest adding a yellow header for that window. This could be the name of the button "Hero movement" or something else corresponding unability of the hero to move anymore...
I'm not that one, who can argue regarding the texts. 😅 From my point "nights" never occur in the game, so referring to them could be misleading. What about any rephrasing using the therm "tomorrow" in the second sentence?

@LeHerosInconnu
Copy link

Hello @zenseii,

What about something more informative in the Hero Movement button info window (displayed with right clic)?
This would allow all buttons to function more consistently and clearly.
Namely, a left click triggers what is described for each button, and a held left click triggers what is described for all buttons.
Image is for explanation only.

Hero button info 04

Ideally, the window should extend horizontally.
Buttons should be positioned to the left of the window, with the text for each button next to it on the right.
This could be done later.

@zenseii
Copy link
Collaborator Author

zenseii commented Jan 26, 2025

Hello, @LeHerosInconnu.

Your suggestion is an improvement to the right-click dialog, and this PR is about one alternative to the left-click dialog. A separate issue can be opened for addressing the right-click dialog, although a discussion should be opened first just to make sure that we have arrived at a final idea for it before we open the issue and someone begins implementing it.

The discussion in #9474 showed that there's wasn't agreement on clearing the path with the left-click and so this PR proposes a solution to the idea of a button click giving feedback in terms of an event, in this case a dialog.

I suggest to keep the discussion about clearing the path with the left-click to #9474.

@Branikolog
Copy link
Collaborator

@zenseii
Everything looks nice. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adventure map, Hero movement button, operation to delete the hero's predefined path
4 participants