-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dialog pop up when pressing standing horse #9486
base: master
Are you sure you want to change the base?
Conversation
This gives feedback when pressing and has the small additional bonus of helping completely new players understand why the hero can't move anymore (I've seen and heard about impatient gamers quit the game after this).
Hi, @zenseii ! It's a nice hint for the new players, to explain the mechanics of replenishing hero's movement points. The new dialog also shows some feedback while clicking on the new "standing" state button. 👍 I suggest adding a yellow header for that window. This could be the name of the button "Hero movement" or something else corresponding unability of the hero to move anymore... |
Hello @zenseii, What about something more informative in the Hero Movement button info window (displayed with right clic)? Ideally, the window should extend horizontally. |
Hello, @LeHerosInconnu. Your suggestion is an improvement to the right-click dialog, and this PR is about one alternative to the left-click dialog. A separate issue can be opened for addressing the right-click dialog, although a discussion should be opened first just to make sure that we have arrived at a final idea for it before we open the issue and someone begins implementing it. The discussion in #9474 showed that there's wasn't agreement on clearing the path with the left-click and so this PR proposes a solution to the idea of a button click giving feedback in terms of an event, in this case a dialog. I suggest to keep the discussion about clearing the path with the left-click to #9474. |
@zenseii |
This PR is a suggested fix/compromise and works as a draft to test. More polish needs to be done before it can be merged.
fix #9474 (proposal)
This gives feedback when pressing and has the small additional bonus of helping completely new players understand why the hero can't move anymore (I've seen and heard about impatient gamers quit the game after this).
fheroes2.engine.version_.1.1.5.2025-01-24.20-46-02.mp4
The current dialog: