Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Fix" mypy issue in CI #119

Merged
merged 2 commits into from
Dec 11, 2024
Merged

"Fix" mypy issue in CI #119

merged 2 commits into from
Dec 11, 2024

Conversation

zhengp0
Copy link
Member

@zhengp0 zhengp0 commented Dec 11, 2024

Descriptions

  • Skip mypy checking for utils.residual, utils.uncertainty and model_stages.rover_stage due to Pandas typing issue
  • Add None type to constraints.base.Constraint.func because default value is None

@kels271828
Copy link
Member

We should create a ticket to fix the mypy issues with pandas

@zhengp0
Copy link
Member Author

zhengp0 commented Dec 11, 2024

We should create a ticket to fix the mypy issues with pandas

Yes! Will do!

@zhengp0 zhengp0 merged commit 7217a6c into release/1.0 Dec 11, 2024
6 of 9 checks passed
@zhengp0 zhengp0 deleted the bugfix/mypy branch December 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kels271828 kels271828 kels271828 approved these changes

@blsmxiu47 blsmxiu47 Awaiting requested review from blsmxiu47

@saalUW saalUW Awaiting requested review from saalUW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhengp0 @kels271828