Skip to content

Commit

Permalink
Fix data race
Browse files Browse the repository at this point in the history
* dont stub after calling method under test

[#85545422]
  • Loading branch information
jfmyers9 committed Apr 2, 2015
1 parent 25a6b14 commit 8ddfe9b
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions route_fetcher/route_fetcher_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ var _ = Describe("RouteFetcher", func() {
eventSource := fake_routing_api.FakeEventSource{}
client.SubscribeToEventsReturns(&eventSource, nil)

tokenFetcher.FetchTokenReturns(token, nil)
fetcher.StartEventCycle()

received := make(chan struct{})

eventSource.NextStub = func() (routing_api.Event, error) {
Expand All @@ -230,6 +227,9 @@ var _ = Describe("RouteFetcher", func() {
return event, nil
}

tokenFetcher.FetchTokenReturns(token, nil)
fetcher.StartEventCycle()

<-received

Expect(registry.UnregisterCallCount()).To(Equal(1))
Expand All @@ -240,16 +240,16 @@ var _ = Describe("RouteFetcher", func() {
eventSource := fake_routing_api.FakeEventSource{}
client.SubscribeToEventsReturns(&eventSource, nil)

tokenFetcher.FetchTokenReturns(token, nil)
fetcher.StartEventCycle()

received := make(chan struct{})

eventSource.NextStub = func() (routing_api.Event, error) {
received <- struct{}{}
return routing_api.Event{}, errors.New("beep boop im a robot")
}

tokenFetcher.FetchTokenReturns(token, nil)
fetcher.StartEventCycle()

<-received

Expect(sink.Records()).ToNot(BeNil())
Expand Down

0 comments on commit 8ddfe9b

Please sign in to comment.