Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix flaky tests, cleanup code #17

Merged
merged 1 commit into from
Dec 1, 2024
Merged

fix: fix flaky tests, cleanup code #17

merged 1 commit into from
Dec 1, 2024

Conversation

ilaborie
Copy link
Owner

@ilaborie ilaborie commented Dec 1, 2024

No description provided.

@ilaborie ilaborie force-pushed the fix/tests branch 3 times, most recently from 01c9e03 to c50eed0 Compare December 1, 2024 10:06
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.4%. Comparing base (c4ce0fa) to head (e3bb9c3).
Report is 4 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
schema-registry-api/src/domain/schema/version.rs 93.5% <ø> (+4.6%) ⬆️

... and 18 files with indirect coverage changes

@ilaborie ilaborie marked this pull request as ready for review December 1, 2024 10:25
@ilaborie
Copy link
Owner Author

ilaborie commented Dec 1, 2024

Issue with minimal version is reported here: TrueLayer/reqwest-middleware#204

@ilaborie ilaborie closed this Dec 1, 2024
@ilaborie ilaborie reopened this Dec 1, 2024
@ilaborie ilaborie merged commit e53c3f2 into main Dec 1, 2024
22 of 24 checks passed
@ilaborie ilaborie deleted the fix/tests branch December 1, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants