Skip to content

Commit

Permalink
stop hiding exceptions
Browse files Browse the repository at this point in the history
excepthook was used before 2b09109
that claims segfaults being cause by it.

Could not reproduce segfaults - and rather have an error message popping
up.
Otherwise in case of exception somewhere along the chain, ilastik looks
like it's doing nothing and one wouldn't know.
  • Loading branch information
k-dominik committed Oct 27, 2023
1 parent 0d0b3e8 commit f3ac824
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
7 changes: 3 additions & 4 deletions volumina/pixelpipeline/datasources/lazyflowsource.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ def wrapper(*args, **kwargs):
return func(*args, **kwargs)
except Slot.SlotNotReadyError as ex:
# Translate lazyflow not-ready errors into the volumina equivalent.
raise_with_traceback(IndeterminateRequestError(ex)).with_traceback(sys.exc_info()[2])
raise IndeterminateRequestError() from ex

Check warning on line 49 in volumina/pixelpipeline/datasources/lazyflowsource.py

View check run for this annotation

Codecov / codecov/patch

volumina/pixelpipeline/datasources/lazyflowsource.py#L49

Added line #L49 was not covered by tests

wrapper.__wrapped__ = func # Emulate python 3 behavior of @functools.wraps
return wrapper
Expand Down Expand Up @@ -105,11 +105,10 @@ def __init__(self, outslot, priority=0):

# Attach an OpReorderAxes to ensure the data will display correctly
# (We include the graph parameter, too, since tests sometimes provide an operator with no parent.)
self._op5 = opReorderAxes.OpReorderAxes(
parent=outslot.operator.parent, graph=outslot.operator.graph
)
self._op5 = opReorderAxes.OpReorderAxes(parent=outslot.operator.parent, graph=outslot.operator.graph)
self._op5.Input.connect(outslot)
self._op5.AxisOrder.setValue("txyzc")
self._op5.name = "reorder_lazyflow_source_to_volumina"

self._priority = priority
self._dirtyCallback = partial(weakref_setDirtyLF, weakref.ref(self))
Expand Down
2 changes: 1 addition & 1 deletion volumina/tiling/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -553,7 +553,7 @@ def _fetch_layer_tile(self, timestamp, ims, transform, tile_nr, stack_id, ims_re
if stack_id == self._current_stack_id and cache is self._cache:
self.sceneRectChanged.emit(tile_rect)
except BaseException:
logger.debug("Failed to fetch layer tile", exc_info=True)
raise

Check warning on line 556 in volumina/tiling/__init__.py

View check run for this annotation

Codecov / codecov/patch

volumina/tiling/__init__.py#L556

Added line #L556 was not covered by tests

def _onLayerDirty(self, dirtyImgSrc, dataRect):
"""
Expand Down

0 comments on commit f3ac824

Please sign in to comment.