Colortables: Provide unique copies of constants #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btbest
force-pushed
the
provide-copies-of-colortable-constants
branch
from
00102cb to
431669a
Compare
When the constants are imported, any modifications to them persist until Python is restarted. Consumers currently have to make their own copy of the constant, which they shouldn't have to.
btbest
force-pushed
the
provide-copies-of-colortable-constants
branch
from
431669a to
0241d60
Compare
k-dominik
approved these changes
Jan 11, 2024
|
lgtm, I hope the test failures observed with the ilastik env where just flaky, let's see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the constants are imported, any modifications to them persist until Python is restarted. Consumers currently have to make their own copy of the constant, which they shouldn't have to.
See ilastik/ilastik#2786