Fix typo "earlier rather than later" #201
Conversation
|
@tudorsiminic see my comments for a little bit of polish. |
Which comments do you refer to ? I'm not seeing them |
|
Is it possible to send another push with the change, |
Did you submit the "comments above"? I don't see them... Here's a screenshot |
background/background.tex
Outdated
| @@ -306,7 +306,7 @@ \subsection{Asserts} | |||
| Here is a quick example with an assert. | |||
| Let's say that we are writing code using memcpy. | |||
| We would want to put an assert before that checks whether my two memory regions overlap. | |||
| If they do overlap, memcpy runs into undefined behavior, so we want to catch that problem than later. | |||
| If they do overlap, memcpy runs into undefined behavior, so we want to catch that problem earlier rather than later. | |||
|
|
|||
| \begin{lstlisting}[language=C] | |||
| assert(!(src < dest+n && dest < src+n)); //Checks overlap | |||
There was a problem hiding this comment.
would this be a more understandable assert ? (Also does not have a "not"; it asserts something is true).
assert( src+n < dest || src >= dest + n); // source should finish before the destination or the source starts after the end of destination
There was a problem hiding this comment.
agreed, sounds good to me
|
@tudorsiminic Perhaps you or Andrew can fix the github actions that build and deploy the coursebook. |
No description provided.