feature: Added LuhnModnSnippet class to Algorithm package #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added LuhnModnSnippet class * Added LuhnModnSnippetTest class * Added LuhnModnSnippet class to README.md
iluwatar
requested changes
Dec 7, 2024
Karim-Ashraf1
force-pushed
the
fix-issue-#115
branch
from
3169576 to
d219c4d
Compare
* Removed the extra empty lines * Respected the alphabetical order of the README.md file and insert Luhn Mod N to the correct position * Checked the code duplication reported by Sonar
Karim-Ashraf1
force-pushed
the
fix-issue-#115
branch
from
d219c4d to
758ab02
Compare
|
|
Hi @iluwatar, Could you review the changes requested for this PR ? |
Closed
iluwatar
approved these changes
Jan 6, 2025
|
Looks good! Thank you for the contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LuhnModnSnippet class
Added LuhnModnSnippetTest class
Added LuhnModnSnippet class to README.md