Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to have a dashed border around a bar #1459

Merged
merged 8 commits into from
Nov 24, 2023

Conversation

k0psutin
Copy link
Contributor

@k0psutin k0psutin commented Oct 16, 2023

Add optional borderDashArray to BarChartRodData and utilize toDashedPath with bar border.

Web:
Näyttökuva 2023-10-16 183207

Android:
Screenshot_1697470672

Closes #1144

@k0psutin k0psutin changed the title Add the option to have a dashed border around a bar #1144 Add the option to have a dashed border around a bar Oct 16, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a2924a) 86.58% compared to head (8c84bde) 86.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1459      +/-   ##
==========================================
+ Coverage   86.58%   86.73%   +0.15%     
==========================================
  Files          45       45              
  Lines        3018     3022       +4     
==========================================
+ Hits         2613     2621       +8     
+ Misses        405      401       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 5, 2023

This PR is approved!
Please fix the discussions then we're ready to merge.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 11, 2023

Bro, you should not merge the master into your branch, you need to rebase your branch. (read more about it here).

I think you need to recreate your branch.
Everything looks green, but merge button is disabled.

image

@k0psutin k0psutin force-pushed the feature/barchart-dashed-border branch from cf4f97c to 02618ca Compare November 16, 2023 18:02
@k0psutin
Copy link
Contributor Author

Ah sorry about that. I reverted the merge and rebased. Hopefully it works now.

@k0psutin
Copy link
Contributor Author

The tests should be okay - I couldn't run the golden tests because of the pixel test failed. I mentioned about this at #1468. I ran the other tests separate from the golden files and they were ok.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 21, 2023

You're right, I just removed the golden tests for now 0ae88cf. I need to learn more about them in the future.
Please rebase one more time

@k0psutin k0psutin force-pushed the feature/barchart-dashed-border branch from 02618ca to 2badcf3 Compare November 21, 2023 07:03
@k0psutin
Copy link
Contributor Author

Now it is rebased again and fixed the test to use TextScaler

@imaNNeo imaNNeo merged commit 0d4faea into imaNNeo:master Nov 24, 2023
4 checks passed
@imaNNeo
Copy link
Owner

imaNNeo commented Nov 24, 2023

Thanks for your contribution!

@k0psutin k0psutin deleted the feature/barchart-dashed-border branch November 24, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add feature to add dashed border around a bar
2 participants