-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the option to have a dashed border around a bar #1459
Add the option to have a dashed border around a bar #1459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1459 +/- ##
==========================================
+ Coverage 86.58% 86.73% +0.15%
==========================================
Files 45 45
Lines 3018 3022 +4
==========================================
+ Hits 2613 2621 +8
+ Misses 405 401 -4 ☔ View full report in Codecov by Sentry. |
This PR is approved! |
Bro, you should not merge the master into your branch, you need to I think you need to recreate your branch. |
cf4f97c
to
02618ca
Compare
Ah sorry about that. I reverted the merge and rebased. Hopefully it works now. |
The tests should be okay - I couldn't run the golden tests because of the pixel test failed. I mentioned about this at #1468. I ran the other tests separate from the golden files and they were ok. |
You're right, I just removed the golden tests for now 0ae88cf. I need to learn more about them in the future. |
02618ca
to
2badcf3
Compare
Now it is rebased again and fixed the test to use TextScaler |
Thanks for your contribution! |
Add optional
borderDashArray
toBarChartRodData
and utilizetoDashedPath
with bar border.Web:
Android:
Closes #1144