Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miss touched section in Pie Chart #1506

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

samir7osny
Copy link

solves #1505

This PR uses the Path.contains instead of complex calculations.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@87f0444). Learn more about missing BASE report.

Files with missing lines Patch % Lines
lib/src/chart/pie_chart/pie_chart_painter.dart 58.33% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage        ?   86.54%           
=======================================
  Files           ?       45           
  Lines           ?     3024           
  Branches        ?        0           
=======================================
  Hits            ?     2617           
  Misses          ?      407           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 26, 2023

Please fix the test CI issues

@moritz157
Copy link

Is there anything left to do on this? I am experiencing the same issue and it would be awesome if this fix could be merged

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 20, 2024

It's ready! Thanks

@imaNNeo imaNNeo merged commit d1e7e66 into imaNNeo:main Oct 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants