Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image/default as default feature #559

Merged
merged 3 commits into from
Mar 16, 2024
Merged

add image/default as default feature #559

merged 3 commits into from
Mar 16, 2024

Conversation

cospectrum
Copy link
Contributor

@cospectrum cospectrum commented Mar 15, 2024

Continuing our discussion about the re-export of the image #557.

image/default should allow to run examples using imageproc::image, otherwise a panic/error may occur (png/jpeg decode, etc).
It seems to me that users will expect this from our re-export.
If they don't need the default image features, then they will do imageproc = { ..., default-features = false } which will lead to image = { ..., default-features = false } internally.

The msrv is increased, see image-rs/image#2168

@theotherphil theotherphil merged commit a864cb2 into image-rs:master Mar 16, 2024
14 checks passed
@theotherphil
Copy link
Contributor

Thanks! Let me know if there’s anything you think needs to go in before the next release, otherwise I’ll just ship what we’ve got around 12 hours from now.

@cospectrum cospectrum deleted the image-features branch March 16, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants