-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add default sourceID configuration fields #223
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d5efc72
to
91e4893
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a non-blocking comment, LGTM 🚀
src/components/Dialog/Dialog.tsx
Outdated
const previouslySelectedSource = | ||
invocationParams?.selectedImage?.selectedSource?.id || | ||
installationParams.sourceID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (non-blocking): I almost called out that the comparison below was in invalid, but seeing what previouslySelectedSource
actually is, I see that its a direct comparison.
I think we should rename this variable previouslySelectedSourceId
and update where needed.
const previouslySelectedSource = | |
invocationParams?.selectedImage?.selectedSource?.id || | |
installationParams.sourceID; | |
const previouslySelectedSourceId = | |
invocationParams?.selectedImage?.selectedSource?.id || | |
installationParams.sourceID; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment:
I can see why that's confusing 😅 , I can update this variable name to make this easier to grok 👍🏼 .
9e4ba4f
to
b086aed
Compare
c500c2c
to
48f8ba6
Compare
b086aed
to
d56b245
Compare
48f8ba6
to
35af9f4
Compare
d56b245
to
49b8339
Compare
35af9f4
to
d272b1a
Compare
49b8339
to
fa4f4f8
Compare
Description
Before
After
Loading indicator
source-dropdown-loading-indicator.mp4
Default source
source-dropdown-default-source.mp4
API KEY Validation
default-source-validation.mp4
Steps to test
npm install
, andpnpm run start
localhost
fieldApps --> Installed Apps --> imgix development --> configure
Checklist
BREAKING CHANGE
in the body of the commit.