-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: update repo config files and documents #112
Open
adevade
wants to merge
15
commits into
imgix:main
Choose a base branch
from
adevade:meta
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config
DocumentationChore
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
@luqven This one should be fine to just read the diff, paired with my notes in the original comment. The updates to composer.json has very detailed commits of what I changed, so config: reindent composer.json with 4 spaces to config: add custom scripts to composer.json could be read commit by commit for extra clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.editorconfig
Helps contributors by making sure their editor is behaving according to our specifications.
More info
.gitattributes
Ignores repo files and tests when exporting this project. For example, when downloading as .zip or when installing via composer. This helps save a few hundred kilobytes for every install.
Examples from other popular PHP projects:
composer.json
Remove
version
field. This is handled automatically by packagist.org with the branches/tags/releases in this repo. This way, you only need to update the version numer in one place for each new release; the constantUrlBuilder::VERSION
.Other changes:
composer.lock
(Related issue build: don't commit thecomposer.lock
file #113)CONTRIBUTING.md
Mostly formatting, fixing a broken link to Code of Conduct and clarifying the composer commands at the bottom. Also using the newly added composer custom script for running the tests.
pint.json
Update preset from
psr12
tolaravel
. Thelaravel
preset is based onpsr12
with some other quality of life improvements. Formatting the code in its current state has no difference between the presets.Another preset available is
symfony
. I don't like that one personally. Mostly because it uses "Yoda style" conditions. Ex:if ($meaning === 42)
becomesif (42 === $meaning)
.Checklist