Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ES6 imports #12

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Use ES6 imports #12

merged 1 commit into from
Jan 9, 2018

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Jan 9, 2018

Goal of this was to do initial ES6-ification of these modules with import/export, not a full ES6-ification of everything. Wanting to use sensor polyfill for adding the Generic Sensors API (via #10), which would need a ES6 module loader anyway, so this is a good time as any.

Also removed the vestigial TouchPanner (outside of polyfill's jurisdiction), as well as a vestigial Util.race (used in webvr-polyfill, not here).

…ear future. Remove TouchPanner options as well for simplicity, as it's no longer in use.
Copy link

@lincolnfrog lincolnfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup pass. Looks great!

@jsantell
Copy link
Contributor Author

jsantell commented Jan 9, 2018

@lincolnfrog thanks for reviewing!

@jsantell jsantell merged commit 106e6cb into master Jan 9, 2018
@jsantell jsantell deleted the es6-imports branch January 9, 2018 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants