Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some basicaly styling tweaks #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jabiertxof
Copy link
Contributor

Basicaly do styling fixes. Also open inkscape and allow set again new inkscape

@imvenx
Copy link
Owner

imvenx commented Feb 4, 2023

My first PR, nice!

A few things that I have noticed:

  • The animations don't work for me, not sure why
  • There is some repeated functionality that I already did on dev branch, but haven't integrated in master, like change inkscape path
  • I have modified probably all 17 files in my dev, so is going to mean merge conflicts evereywhere

My bad for not merging master with dev before, but we could communicate better next time so we coordinate efforts better.

I don't think it is going to be possible to merge this PR, but I like many of the style tweaks, and I'm going to try to pick them and integrate them. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants