Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_watersurfaces(): updates to PR #192 #193

Merged
merged 2 commits into from
Jan 7, 2025
Merged

read_watersurfaces(): updates to PR #192 #193

merged 2 commits into from
Jan 7, 2025

Conversation

florisvdh
Copy link
Member

@florisvdh florisvdh commented Jan 6, 2025 •
edited
Loading

This amends PR #192:

  • Discard .data from tidyselect expressions in across()
  • Replace matches() with any_of()

@florisvdh florisvdh requested a review from cecileherr January 6, 2025 13:25
@florisvdh florisvdh mentioned this pull request Jan 6, 2025
Merged
cecileherr
cecileherr approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@cecileherr cecileherr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, it sounds logical!

@cecileherr cecileherr merged commit e59b42a into update_read_ws_en_ws_hab_2024 Jan 7, 2025
3 checks passed
@cecileherr cecileherr deleted the watsurf_udpates_fv branch January 7, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecileherr cecileherr cecileherr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florisvdh @cecileherr