Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use error covariance structures from STATO #306

Merged
merged 5 commits into from
Apr 20, 2015

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Apr 16, 2015

Following discussions at ISA-tools/stato#28, this is a proposal to:

  • re-use stato: 'covariance structure' in place of nidm:ErrorDependence.
  • re-use stato: 'compound symmetry covariance structure' in place of nidm:CompoundSymmetricNoise.

@nicholst: could you help me in finding out if there is a match for some of these nidm terms:
image
in the current set of covariance structures defined in STATO:
image

(Once the discussion will be fully implemented at ISA-tools/stato#28, we will replace all nidm terms currently defined as children of stato:'covariance structure'.)

@nicholst
Copy link
Contributor

@cmaumet, surprisingly, these don't map so well.

  • nidm:ArbitrarilyCorrelatedError: amazingly, STATO seems to have omitted SAS's "Unstructured" covariance structure. I've raised this with an addition to STATO's Dependence structure ISA-tools/stato#28. So, no reference for now.
  • nidm:ExchangeableError: This can reference STATO's "compound symmetry", but in fact is more general -- compound symmetry is just about correlations/covariances, while "exchangeability" refers to the entire multivariate distribution. "Gaussian variables that are exchangeable are compound symmetric."
  • nidm:IndependentError - Again, no love in STATO; raised in my Dependence structure ISA-tools/stato#28 update.
  • nidm:SeriallyCorrelatedError - Finally! This maps exactly to 'Toeplitz covariance structure'

@jbpoline
Copy link
Contributor

I was a little puzzled as well.

+1 For SeriallyCorrelatedError == Toeplitz. (in case of stationarity, always assumed for fMRI...)

cmaumet added 2 commits April 20, 2015 09:37
(now having stato:'covariance structure' as range)
@cmaumet
Copy link
Member Author

cmaumet commented Apr 20, 2015

Thank you @nicholst and @jbpoline! Re-use of stato:'Toeplitz covariance structure' is now implemented. #312 is open to remind us to replace the remaining error dependence terms once ISA-tools/stato#28 is closed.

I will now merge those changes.

@cmaumet cmaumet added the merge label Apr 20, 2015
cmaumet pushed a commit that referenced this pull request Apr 20, 2015
Re-use error covariance structures from STATO
@cmaumet cmaumet merged commit cb7429c into incf-nidash:master Apr 20, 2015
@cmaumet cmaumet deleted the def_error_covar branch April 20, 2015 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants