-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for template url #24
Open
IbrahimHd
wants to merge
9
commits into
incuna:master
Choose a base branch
from
IbrahimHd:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+34
−6
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e9900d1
Support for template URL
IbrahimHd 352f29c
Update README.md
IbrahimHd c8a831b
Support for template URL
IbrahimHd f2ae07e
Support for template URL
IbrahimHd 0f9f2f2
Support for template URL
IbrahimHd 4d792fa
Support for template URL
IbrahimHd ef8bf34
Support for template URL
IbrahimHd 73354b0
Removing the word "custom", so it's about directives in general
IbrahimHd dc4fef1
fixing code style
IbrahimHd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# angular-bind-html-compile | ||
This repo contains a bower package that provides an angular directive which can be passed trusted html with angular template content to evaluate. | ||
|
||
The `bind-html-compile` directive allows for HTML containing directives to be compiled. | ||
The `bind-html-compile` directive allows for HTML containing **custom** directives to be compiled. | ||
|
||
You should only use this directive where the content is coming from a trusted | ||
source. | ||
|
@@ -16,16 +16,25 @@ Add dependency to your app module | |
* `'angular-bind-html-compile'` | ||
|
||
## Usage | ||
`ng-bind-html`: | ||
Just like the standard `ng-bind-html`, `bind-html-compile` goes like this: | ||
``` | ||
<div ng-bind-html="data.content"></div> | ||
<div bind-html-compile="data.content"></div> | ||
``` | ||
|
||
If the `data.content` contained a directive, it would not be compiled. | ||
(Unlike the standard `ng-bind-html`, `bind-html-compile` compiles directives, and even those custom ones.) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Again adding the information about "custom directives" is probably too much There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "custom" taken out |
||
|
||
`bind-html-compile`: | ||
`template-url` attribute can be used to load a template file: | ||
``` | ||
<div bind-html-compile="data.content"></div> | ||
<div bind-html-compile template-url="data.templateUrl"></div> | ||
``` | ||
or a static path: | ||
``` | ||
<div bind-html-compile template-url="'partials/myTemplate.html'"></div> | ||
``` | ||
|
||
Also both attributes can be used together for loading a "piece of html code" as well as a "template file": | ||
``` | ||
<div bind-html-compile="data.content" template-url="data.templateUrl"></div> | ||
``` | ||
|
||
## Development | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that this change is needed, since it doesn't matter if these are custom or angular core directives
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"custom" taken out