IWF-364: Fix conditional complete on messages of internalChannels fro…

…m state APIs (#490)

integ/conditional_close_test.go

@@ -143,8 +143,14 @@ func doTestConditionalForceCompleteOnChannelEmptyWorkflow(
 	history, _ := wfHandler.GetTestResult()
 
 	expectMap := map[string]int64{
-		"S1_start":  3,
-		"S1_decide": 3,
+		"S1_start":  4,
+		"S1_decide": 4,
+	}
+	if useSignalChannel {
+		expectMap = map[string]int64{
+			"S1_start":  3,
+			"S1_decide": 3,
+		}
 	}
 	if !useSignalChannel {
 		expectMap[conditionalClose.RpcPublishInternalChannel] = 3
@@ -153,9 +159,17 @@ func doTestConditionalForceCompleteOnChannelEmptyWorkflow(
 
 	assertions.Equal(iwfidl.COMPLETED, resp2.GetWorkflowStatus())
 	assertions.Equal(1, len(resp2.GetResults()))
-	assertions.Equal(iwfidl.StateCompletionOutput{
+	expectedOutput := iwfidl.StateCompletionOutput{
 		CompletedStateId:          "S1",
-		CompletedStateExecutionId: "S1-3",
+		CompletedStateExecutionId: "S1-4",
 		CompletedStateOutput:      &conditionalClose.TestInput,
-	}, resp2.GetResults()[0])
+	}
+	if useSignalChannel {
+		expectedOutput = iwfidl.StateCompletionOutput{
+			CompletedStateId:          "S1",
+			CompletedStateExecutionId: "S1-3",
+			CompletedStateOutput:      &conditionalClose.TestInput,
+		}
+	}
+	assertions.Equal(expectedOutput, resp2.GetResults()[0])
 }

integ/workflow/conditional_close/routers.go

@@ -109,10 +109,19 @@ func (h *handler) ApiV1WorkflowStateDecide(c *gin.Context) {
 		h.invokeHistory[req.GetWorkflowStateId()+"_decide"]++
 		if req.GetWorkflowStateId() == State1 {
 
+			var internalChanPub []iwfidl.InterStateChannelPublishing
 			context := req.GetContext()
 			if context.GetStateExecutionId() == "S1-1" {
 				// wait for 3 seconds so that the channel can have a new message
 				time.Sleep(time.Second * 3)
+			} else if context.GetStateExecutionId() == "S1-3" {
+				// send internal channel message within the state execution
+				// and expecting the messages are processed by the conditional check
+				internalChanPub = []iwfidl.InterStateChannelPublishing{
+					{
+						ChannelName: TestChannelName,
+						Value:       &TestInput,
+					}}
 			}
 
 			conditionalClose := &iwfidl.WorkflowConditionalClose{
@@ -131,6 +140,7 @@ func (h *handler) ApiV1WorkflowStateDecide(c *gin.Context) {
 			}
 
 			c.JSON(http.StatusOK, iwfidl.WorkflowStateDecideResponse{
+				PublishToInterStateChannel: internalChanPub,
 				StateDecision: &iwfidl.StateDecision{
 					NextStates: []iwfidl.StateMovement{
 						{