Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: proactively restore dead node's availability #72

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

medcl
Copy link
Member

@medcl medcl commented Jan 23, 2025

What does this PR do

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@medcl
Copy link
Member Author

medcl commented Jan 23, 2025

=== RUN Test_LayeredCache_ResizeOnTheFly
layeredcache_test.go:233:
Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:233
Error: Not equal:
expected: 1
actual : 2
Test: Test_LayeredCache_ResizeOnTheFly
layeredcache_test.go:235:
Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:235
Error: Expected nil, but got: &ccache.Item{key:"a", group:"1", promotions:0, refCount:0, expires:1737600932936515146, size:1, value:1, element:(*list.Element)(0xc000355320)}
Test: Test_LayeredCache_ResizeOnTheFly
layeredcache_test.go:243:
Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:243
Error: Expected nil, but got: &ccache.Item{key:"a", group:"2", promotions:1, refCount:0, expires:1737600932936515727, size:1, value:2, element:(*list.Element)(0xc000355350)}
Test: Test_LayeredCache_ResizeOnTheFly

@medcl
Copy link
Member Author

medcl commented Jan 23, 2025

=== RUN Test_LayeredCache_ResizeOnTheFly layeredcache_test.go:233: Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:233 Error: Not equal: expected: 1 actual : 2 Test: Test_LayeredCache_ResizeOnTheFly layeredcache_test.go:235: Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:235 Error: Expected nil, but got: &ccache.Item{key:"a", group:"1", promotions:0, refCount:0, expires:1737600932936515146, size:1, value:1, element:(*list.Element)(0xc000355320)} Test: Test_LayeredCache_ResizeOnTheFly layeredcache_test.go:243: Error Trace: /home/runner/go/src/infini.sh/framework/lib/cache/layeredcache_test.go:243 Error: Expected nil, but got: &ccache.Item{key:"a", group:"2", promotions:1, refCount:0, expires:1737600932936515727, size:1, value:2, element:(*list.Element)(0xc000355350)} Test: Test_LayeredCache_ResizeOnTheFly

seems not stable.

@silenceqi silenceqi merged commit cf33fc7 into main Jan 23, 2025
5 checks passed
@silenceqi silenceqi deleted the recovery_dead_node branch January 23, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants