refactor: const for ip zero or loopback address #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes changes to centralize and standardize the use of network address constants across the codebase. The most important changes include the introduction of new constants for reserved and local addresses, and the replacement of hardcoded address strings with these constants.
Centralization and standardization of network address constants:
core/util/netutils.go
: Introduced new constantsReservedAddress
,LocalIpv6Address
, andLocalAddress
to represent common network addresses.core/util/netutils.go
: Replaced hardcoded address strings with the newly defined constants in various functions, such asGetSafetyInternalAddress
,GetValidAddress
,GetLocalIPs
, andClientIP
. [1] [2] [3] [4]Refactoring to use new address constants:
core/api/api.go
: Updated theStartAPI
function to use theReservedAddress
constant instead of the hardcoded "0.0.0.0" string.core/host/process_info.go
: Imported theutil
package and replaced hardcoded address strings with the new constants in thegetPortByPidWindows
function. [1] [2]Rationale for this change
Standards checklist