Allowing to exclude subdomains by a regular expression #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinst
force-pushed
the
excluded_subdomains_regex
branch
from
ccdcb52 to
193ca97
Compare
caironoleto
suggested changes
Feb 24, 2017
| expect(described_class.excluded_subdomain?("cereal")).to eq(true) | ||
| expect(described_class.excluded_subdomain?("flakes")).to eq(false) | ||
|
|
||
| described_class.excluded_subdomains = nil |
There was a problem hiding this comment.
You can use after:
after { described_class.excluded_subdomains = nil }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was with this problem, there is a set of subdomains that start with "staging-pr-" then a number and I couldn't do nothing besides generating a huge array from "staging-pr-1" to "staging-pr-9999", and even with this, when I get more then 9999 pull requests on my app, it would stop to work.
So, I implemented to match the excluded subdomain if it is a regexp. The way I made you can even mix them with strings.
Thank you!