feat: add precision flag to write subcommand #25935
Conversation
waynr
changed the title
| @@ -903,6 +906,21 @@ pub enum Precision { | |||
| Nanosecond, | |||
| } | |||
|
|
|||
| impl std::str::FromStr for Precision { | |||
There was a problem hiding this comment.
Can we re-use whatever it is that parses the precision argument from the HTTP API? That way they're always the exact same.
There was a problem hiding this comment.
Several types are duplicated in this crate, e.g., Format, from the influxdb3_server crate. Perhaps we should pull influxdb3_server as a dependency of influxdb3_client and re-use them directly, or move the types to a central crate.
But this has bit us a couple times now.
There was a problem hiding this comment.
I looked into the type used for the HTTP API since my initial grep for an appropriate type turned up both, but it looks to me like the HTTP API uses serde deserialization where the HTTP request body refers to the precision types as "second", "millisecond", etc (as opposed to "s", "ms", etc).
Even if we wanted to use the full word for precision unit for the CLI, we would still need to impl FromStr, which is what clap uses to parse arguments.
@hiltontj I did notice the TODOs in the code around consolidating types between crates -- is there a github issue tracking that? I could look into that after this PR.
Addresses #25930
This adds simple
--precisionflag to theinfluxdb3 writesubcommand along with round trip write/query tests to validate the resulting timestamp precision in the query output.