Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(inputs.nvidia_smi): Implement probing #16305

Merged
merged 1 commit into from
Jan 28, 2025
Merged

feat(inputs.nvidia_smi): Implement probing #16305

merged 1 commit into from
Jan 28, 2025

Conversation

LandonTClipp
Copy link
Contributor

@LandonTClipp LandonTClipp commented Dec 13, 2024 •
edited
Loading

Summary

This PR implements tsd-009 for the inputs.nvidia_smi plugin. This is achieved by running nvidia-smi once and checking the return code for a successful run.

Checklist

  • No AI generated code was used in this PR

Related issues

@LandonTClipp LandonTClipp changed the title WIP: feat(plugins.nvidia_smi): Implement Probe() feat(plugins.nvidia_smi): Implement Probe() Dec 13, 2024
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Dec 13, 2024
@LandonTClipp LandonTClipp marked this pull request as ready for review December 13, 2024 19:29
srebhan
srebhan requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @LandonTClipp! I do have two comments in the code and want to ask you to split the PR into

  1. adding the probing framework
  2. adding probing support to NVidia SMI

models/running_input.go Outdated Show resolved Hide resolved
agent/agent_test.go Outdated Show resolved Hide resolved
@srebhan srebhan self-assigned this Dec 17, 2024
@LandonTClipp
Copy link
Contributor Author

Will do!

@LandonTClipp LandonTClipp mentioned this pull request Dec 19, 2024
Merged
1 task
@LandonTClipp LandonTClipp marked this pull request as draft December 19, 2024 17:42
@LandonTClipp
Copy link
Contributor Author

Converting to draft until #16333 is merged.

@LandonTClipp LandonTClipp force-pushed the LandonTClipp/nvidia_smi_probe branch 2 times, most recently from 8af2973 to 7af74e0 Compare January 22, 2025 22:13
@LandonTClipp
feat(plugins.nvidia_smi): Implement Probe()
f6d6329 
This PR implements [tsd-009](https://github.com/influxdata/telegraf/blob/master/docs/specs/tsd-009-probe-on-startup.md) for the `inputs.nvidia_smi` plugin. This is achieved by running nvidia-smi once and checking the return code for a successful run.
@LandonTClipp LandonTClipp force-pushed the LandonTClipp/nvidia_smi_probe branch from 7af74e0 to f6d6329 Compare January 22, 2025 22:15
@LandonTClipp LandonTClipp marked this pull request as ready for review January 22, 2025 22:15
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @LandonTClipp! Thanks!

@srebhan srebhan changed the title feat(plugins.nvidia_smi): Implement Probe() feat(inputs.nvidia_smi): Implement probing Jan 23, 2025
@telegraf-tiger telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Jan 23, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jan 23, 2025
@srebhan srebhan assigned DStrand1 and unassigned srebhan Jan 23, 2025
@DStrand1 DStrand1 merged commit c2c9a09 into influxdata:master Jan 28, 2025
29 checks passed
@github-actions github-actions bot added this to the v1.34.0 milestone Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@DStrand1 DStrand1

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@LandonTClipp @srebhan @DStrand1