Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump nanoid from 3.2.0 to 3.3.8 #6988

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

jdstrand
Copy link
Contributor

@jdstrand jdstrand commented Dec 18, 2024

This fixes nanoid more completely for https://github.com/influxdata/ui/security/dependabot/100. #6986 updated yarn.lock for the dependencies. This updates package.json so that dependencies will correctly contain 3.3.8 instead of 3.2.0 (but yarn.lock stays the same for this resolution) and updates resolutions to use 3.3.8 for 3.3.3 in the mocha devDependency.

In terms of runtime effects, there are no changes for prod and we now use 3.3.8 for the mocha devDependency.

Closes https://github.com/influxdata/idpe/issues/19022

@jdstrand jdstrand requested review from a team as code owners December 18, 2024 12:44
@wdoconnell
Copy link
Contributor

@jdstrand It looks like this is failing on a test that shouldn't exist anymore: a test for the C2 subscriptions feature. Let me look into how that's still in there - I had thought those tests were ripped out.

@wdoconnell wdoconnell enabled auto-merge December 18, 2024 14:24
@wdoconnell
Copy link
Contributor

@jdstrand It looks like this is failing on a test that shouldn't exist anymore: a test for the C2 subscriptions feature. Let me look into how that's still in there - I had thought those tests were ripped out.

The tests were indeed ripped out in September, so there is no reason they should be used here. I am re-running it to replicate, but this could be a caching issue on one of the self hosted runners -- not sure. If so, I can ask TKY for the IPs to go in manually and clear the caches.

@wdoconnell wdoconnell added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@wdoconnell wdoconnell added this pull request to the merge queue Dec 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@wdoconnell wdoconnell added this pull request to the merge queue Dec 18, 2024
@wdoconnell
Copy link
Contributor

Not sure what was going on with the use of the old subscriptions test, it looks like this was just scriptQueryBuilder flake.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 18, 2024
@jdstrand jdstrand added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 9f138ec Dec 18, 2024
7 checks passed
@jdstrand jdstrand deleted the jdstrand/update-nanoid branch December 18, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants