Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify env.ts more specifically for newer node versions #7000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wdoconnell
Copy link
Contributor

@wdoconnell wdoconnell commented Jan 28, 2025

Module resolution has changed with Node 23.6.0. Node permits importing ESM with require statements, but require statements now require specifying rather than inferring a file extension. This breaks production builds with Node versions >= 23.6.0. Thank you to @philjb for identifying this.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

@wdoconnell wdoconnell requested review from a team as code owners January 28, 2025 02:14
Copy link
Contributor

@david-rusnak david-rusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wdoconnell wdoconnell force-pushed the specify-env-ts-for-newer-node branch 2 times, most recently from 725a453 to 67ccc12 Compare January 28, 2025 15:06
Copy link
Contributor

@philjb philjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad it wasn't just on my machine! thanks for your help.

@jdstrand
Copy link
Contributor

jdstrand commented Jan 28, 2025

I'm glad it wasn't just on my machine! thanks for your help.

I'll also note (to state the obvious) that we use node LTS releases (which 23 is not one of them) which is why this didn't show up in CI. 24 will be the next LTS soon, so it's good to fix this. Thanks @philjb and @wdoconnell!

philjb added a commit that referenced this pull request Jan 29, 2025
philjb added a commit that referenced this pull request Jan 29, 2025
@philjb
Copy link
Contributor

philjb commented Jan 29, 2025

I dunno what to make of this monitor-ci failure in the remocal-smoke-test

curl: (77) error setting certificate verify locations:  CAfile: /etc/ssl/certs/ca-certificates.crt CApath: /etc/ssl/certs
sha256sum: /usr/local/bin/kubectl: No such file or directory
/usr/local/bin/kubectl: FAILED open or read
sha256sum: WARNING: 1 listed file could not be read

Exited with code exit status 1

@jdstrand
Copy link
Contributor

jdstrand commented Jan 29, 2025

@philjb - @wdoconnell noticed this and asked Opeyemi to take a look (as it has something to do with k8s-idpe).

@wdoconnell wdoconnell force-pushed the specify-env-ts-for-newer-node branch 2 times, most recently from 6c4a55e to 79393ff Compare February 5, 2025 17:54
@wdoconnell wdoconnell force-pushed the specify-env-ts-for-newer-node branch from 79393ff to 6dadd6f Compare February 5, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants