-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: specify env.ts more specifically for newer node versions #7000
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
725a453
to
67ccc12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad it wasn't just on my machine! thanks for your help.
I'll also note (to state the obvious) that we use node LTS releases (which 23 is not one of them) which is why this didn't show up in CI. 24 will be the next LTS soon, so it's good to fix this. Thanks @philjb and @wdoconnell! |
* cherry-pick of #7000 Co-authored-by: Bill OConnell <[email protected]>
* cherry-pick of #7000 Co-authored-by: Bill OConnell <[email protected]>
I dunno what to make of this monitor-ci failure in the remocal-smoke-test
|
@philjb - @wdoconnell noticed this and asked Opeyemi to take a look (as it has something to do with k8s-idpe). |
6c4a55e
to
79393ff
Compare
79393ff
to
6dadd6f
Compare
Module resolution has changed with Node 23.6.0. Node permits importing ESM with require statements, but require statements now require specifying rather than inferring a file extension. This breaks production builds with Node versions >= 23.6.0. Thank you to @philjb for identifying this.
Checklist
Authors and Reviewer(s), please verify the following: