Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pull_request trigger for ci:test:deploy #1112

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

The `workflow_run` trigger should be enough.
@make-github-pseudonymous-again make-github-pseudonymous-again added ci This issue is about continuous integration dx This is about developer experience labels Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.15%. Comparing base (34d9b8f) to head (0ae8d20).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1112      +/-   ##
==========================================
- Coverage   73.16%   73.15%   -0.01%     
==========================================
  Files         772      772              
  Lines       11915    11915              
  Branches     1455     1455              
==========================================
- Hits         8718     8717       -1     
- Misses       2696     2697       +1     
  Partials      501      501              
Flag Coverage Δ
client 53.21% <ø> (+<0.01%) ⬆️
server 61.85% <ø> (-0.03%) ⬇️
test 77.78% <ø> (-0.02%) ⬇️
test-app 58.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as ready for review January 27, 2025 10:18
@make-github-pseudonymous-again make-github-pseudonymous-again marked this pull request as draft January 27, 2025 10:19
@make-github-pseudonymous-again
Copy link
Contributor Author

make-github-pseudonymous-again commented Jan 27, 2025

It does not work since pull_request triggers are required for "required checks". See for instance:

This might be worked around via "required deployments":

Require deployments to succeed before merging
Choose which environments must be successfully deployed to before branches can be merged into a branch that matches this rule.

But at this point I think it would be simpler to just merge all dependent jobs into a single workflow, as suggested in:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This issue is about continuous integration dx This is about developer experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant