Add client update command for Cosmos chains
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soareschen
reviewed
Feb 12, 2024
Comment on lines
100
to
107
| let height = reference_chain | ||
| .with_blocking_chain_handle(|handle| { | ||
| handle | ||
| .query_latest_height() | ||
| .map_err(|e| BaseError::relayer(e).into()) | ||
| }) | ||
| .await | ||
| .wrap_err("Failed to fetch latest height on reference chain")?; |
There was a problem hiding this comment.
We can use CanQueryChainHeight to query the latest chain height here.
Suggested change
| let height = reference_chain | |
| .with_blocking_chain_handle(|handle| { | |
| handle | |
| .query_latest_height() | |
| .map_err(|e| BaseError::relayer(e).into()) | |
| }) | |
| .await | |
| .wrap_err("Failed to fetch latest height on reference chain")?; | |
| let height = reference_chain.query_chain_height().await?; |
soareschen
reviewed
Feb 12, 2024
| let reference_chain_id = client_state.chain_id; | ||
| let reference_chain = builder.build_chain(&reference_chain_id).await?; | ||
|
|
||
| let relayer = CanBuildRelay::build_relay( |
There was a problem hiding this comment.
Let's rename CosmosBuilder::build_relay to CosmosBuilder::build_cosmos_relay, so that we can use builder.build_relay() here without the method name ambiguity.
soareschen
reviewed
Feb 12, 2024
| // help_heading = "Update the client across a genesis restart", | ||
| // help = "The height that the chain underwent a genesis restart at. Requires --archive-address if used." | ||
| // )] | ||
| // restart_height: Option<u64>, |
There was a problem hiding this comment.
Let's remove the commented CLI options for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #144
Description
Not all arguments of its v1 counterpart have been implemented yet. We can do this in a separate pass.
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.