Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate legacy tests #495

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Migrate legacy tests #495

merged 9 commits into from
Dec 11, 2024

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Dec 9, 2024 •
edited
Loading

Closes: #XXX

Description

This PR migrates the following legacy tests from tools crate:

  • Packet clearing test
  • Packet filtering test
  • Packet timeout test
  • Acknowledgment relaying test

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 marked this pull request as ready for review December 11, 2024 08:06
@ljoss17 ljoss17 requested a review from soareschen December 11, 2024 08:28
@soareschen soareschen merged commit 01813c1 into main Dec 11, 2024
10 checks passed
@soareschen soareschen deleted the luca_joss/migrate-legacy-tests branch December 11, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soareschen soareschen soareschen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ljoss17 @soareschen