Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cat-voices): Using TimezoneText in ProposalCard #1711

Merged
merged 13 commits into from
Jan 30, 2025
Merged

chore(cat-voices): Using TimezoneText in ProposalCard #1711

merged 13 commits into from
Jan 30, 2025

Conversation

LynxLynxx
Copy link
Contributor

Description

To make it more readable I change Text widget to TimezoneText which is sensitive to the timezone that the user has selected. Also, I found in another Figma view that proposalcard should have a hover effect.

Related Pull Requests

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 445/445}$ | ${\color{red}Fail: 0/445}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 447/447}$ | ${\color{red}Fail: 0/447}$ |

@damian-molinski damian-molinski added the dart Pull requests that update Dart code label Jan 28, 2025
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 448/448}$ | ${\color{red}Fail: 0/448}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 448/448}$ | ${\color{red}Fail: 0/448}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 448/448}$ | ${\color{red}Fail: 0/448}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 448/448}$ | ${\color{red}Fail: 0/448}$ |

LynxLynxx and others added 2 commits January 29, 2025 17:54
@LynxLynxx
refactor: Improve PendingProposalCard and add ProposalPublish.isPubli…
fc27d36 
…shed method

- Updated PendingProposalCard for better state management.
- Added isPublished method to ProposalPublish enum
@LynxLynxx
Merge branch 'main' into chore/timezone_date_time_proposal_card
2cf6306
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 452/452}$ | ${\color{red}Fail: 0/452}$ |

@LynxLynxx
refactor(pending-proposal-card): update border color on publish stage…
b85222a 
… change

The `_ProposalBorderColor` is now updated when the proposal's publish stage changes. Also, the name of the border variable changed to `_border`.
@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 452/452}$ | ${\color{red}Fail: 0/452}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 452/452}$ | ${\color{red}Fail: 0/452}$ |

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 452/452}$ | ${\color{red}Fail: 0/452}$ |

damian-molinski
damian-molinski approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@damian-molinski damian-molinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

✅ Test Report | ${\color{lightgreen}Pass: 455/455}$ | ${\color{red}Fail: 0/455}$ |

@LynxLynxx LynxLynxx merged commit 66bb1bc into main Jan 30, 2025
40 of 42 checks passed
@LynxLynxx LynxLynxx deleted the chore/timezone_date_time_proposal_card branch January 30, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtscalac dtscalac dtscalac left review comments

@damian-molinski damian-molinski damian-molinski approved these changes

Assignees

@LynxLynxx LynxLynxx

Labels
dart Pull requests that update Dart code
Projects
Catalyst
Status: ✅ Done
Milestone
Fund14 Technical Readiness
Development

Successfully merging this pull request may close these issues.
3 participants
@LynxLynxx @damian-molinski @dtscalac