Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cat-gateway): Remove #[allow(dead_code)] where it is actually not dead code #1734

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jan 30, 2025

Description

Removed #[allow(dead_code)] where it is actually not dead code.

Related Issue(s)

Closes #1721

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem added do not merge yet PR is not ready to be merged yet draft Draft rust Pull requests that update Rust code labels Jan 30, 2025
@apskhem apskhem self-assigned this Jan 30, 2025
@apskhem apskhem linked an issue Jan 30, 2025 that may be closed by this pull request
70 tasks
@apskhem apskhem marked this pull request as draft January 30, 2025 09:38
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 449/449}$ | ${\color{red}Fail: 0/449}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 455/455}$ | ${\color{red}Fail: 0/455}$ |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet draft Draft rust Pull requests that update Rust code
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Remove all dead code annotations
1 participant