-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-563] Re-enable wallet import feature #2308
Conversation
Developed it as a standalone library, feel free to rip it apart the way you like. ``` restore-keystore ├── index.spec.ts ├── index.ts ├── jest.config.ts ├── LICENSE ├── NOTICE ├── package.json ├── package-lock.json └── __test__ └── secret.key ``` It's shipped with a default test keystore that I've been previously using on input-output-hk/cardano-sl#4278 and a test suite which controls that this new implementation yield the same results. ```console > [email protected] test /home/ktorz/Documents/IOHK/restore-keystore > jest PASS ./index.spec.ts walletId ✓ 0 (2 ms) ✓ 1 ✓ 2 (1 ms) ✓ 3 encryptedPayload ✓ 0 ✓ 1 (1 ms) ✓ 2 ✓ 3 passphraseHash ✓ 0 (1 ms) ✓ 1 ✓ 2 ✓ 3 isEmptyPassphrase ✓ 0 ✓ 1 ✓ 2 ✓ 3 Test Suites: 1 passed, 1 total Tests: 16 passed, 16 total Snapshots: 0 total Time: 2.3 s, estimated 3 s Ran all test suites. ``` The magic is yours now and should help resolving #1234.
Can be used directly (after `npm install`) as an executable, e.g.: ``` $ ./restore-keystore.ts __test__/secret.key [...] ``` ``` $ ./restore-keystore.ts $HOME/.local/share/Daedalus/mainnet/Secrets/secret.key [...] ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested on Mac:Mainnet, Linux:Flight, Windows:Flight on build 16404. Great work @nikolaglumac 👍
Where can I download this build from? |
@jsindy please wait for it to be officially released on https://daedaluswallet.io/en/flight/ |
understood, any docs on building from source? |
You can try these steps:
|
This PR re-enables wallet import feature.
Todos
Screenshots
Test checklist
Secret123
)Test cases
Documentation
Developed it as a standalone library, feel free to rip it apart the way you like.
It's shipped with a default test keystore that I've been previously using on input-output-hk/cardano-sl#4278 and a test suite which controls that this new implementation yield the same results.
The magic is yours now and should help resolving #1234.
PS: Sorry I ditched away the PR template, it's rude but I guess I am a bit rude myself.