Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: enhance inputs for nightly workflows #2200

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 6, 2025

Content

This PR includes enhancements on inputs support for workflow triggered with the Nightly Dispatcher workflow.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@jpraynaud jpraynaud self-assigned this Jan 6, 2025
Copy link

github-actions bot commented Jan 6, 2025

Test Results

    4 files  ±0     52 suites  ±0   10m 34s ⏱️ +11s
1 470 tests ±0  1 470 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 726 runs  ±0  1 726 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 99351ae. ± Comparison against base commit 27cee3f.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/aggregator-stress-test.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud force-pushed the jpraynaud/enhance-input-nightly-workflows branch from 5505c0b to 99351ae Compare January 6, 2025 13:21
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet January 6, 2025 13:30 — with GitHub Actions Inactive
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpraynaud jpraynaud merged commit 00567fe into main Jan 6, 2025
51 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/enhance-input-nightly-workflows branch January 6, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants