Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KUN-8981 | (feat) Add url chooser without xhr call #36

Open
wants to merge 3 commits into
base: insiders
Choose a base branch
from
Open

KUN-8981 | (feat) Add url chooser without xhr call #36

wants to merge 3 commits into from

Conversation

mart-insiders
Copy link

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? yes

@mart-insiders mart-insiders requested a review from dannyvw August 28, 2024 09:08
@mart-insiders mart-insiders self-assigned this Aug 28, 2024
dannyvw
dannyvw reviewed Aug 29, 2024
View reviewed changes
src/Kunstmaan/NodeBundle/Form/Type/InternalURLSelectorType.php Outdated Show resolved Hide resolved
src/Kunstmaan/NodeBundle/Form/Type/InternalURLSelectorType.php Outdated
]);
}

public function getBlockPrefix()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type

src/Kunstmaan/NodeBundle/Form/Type/URLChooserType.php Show resolved Hide resolved
src/Kunstmaan/NodeBundle/Form/Type/URLTypeType.php Outdated Show resolved Hide resolved
@dannyvw
Copy link

dannyvw commented Sep 3, 2024

External ipv internal is nu de default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyvw dannyvw dannyvw requested changes

Assignees

@mart-insiders mart-insiders

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mart-insiders @dannyvw