-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX improvements #6
Conversation
🧪 Test coverage: 65.38% Code Coverage Summary
Diff against main
Results for commit: 166cc98 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. viper does not give you the option for CLI tags precedence over config file inputs out-of-the-box?
It does, and user can still specify these values in config file as |
I also think this kind of implementation (where we use different flag/key names depending on whether the argument is a string or a list of strings), is cleaner and more readable as compared to using the same argument name but storing string or list of strings, depending on whether it comes from a CLI flag, or the config file. |
Got it, and agreed. It is much cleaner this way. Thanks for the detailed explanation. Good to go! |
Closes #5.