Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace scda with random.cdisc.data #170

Merged
merged 13 commits into from
Apr 10, 2024
Merged

Replace scda with random.cdisc.data #170

merged 13 commits into from
Apr 10, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Apr 9, 2024

Closes #154

@vedhav vedhav added the core label Apr 9, 2024
@kartikeyakirar kartikeyakirar self-assigned this Apr 10, 2024
Copy link
Contributor

github-actions bot commented Apr 10, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
@kartikeyakirar
Copy link
Contributor

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedhav can you search and remove scda and scda.2022 from tm_front_page module used in all the apps?
e.g
https://github.com/insightsengineering/teal.gallery/blob/main/exploratory/app.R#L217-L225

@vedhav
Copy link
Contributor Author

vedhav commented Apr 10, 2024

Thanks, done in 0900320

Copy link
Contributor

@kartikeyakirar kartikeyakirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vedhav Great job, LGTM 🚀

@vedhav vedhav enabled auto-merge (squash) April 10, 2024 12:17
@vedhav vedhav merged commit 7694839 into main Apr 10, 2024
@vedhav vedhav deleted the 154-use-rcd@main branch April 10, 2024 12:17
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: remove {scda*} packages, and use {random.cdisc.data}
2 participants