Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showcase different teal_slices in Basic teal app + update header and footer #172

Merged
merged 4 commits into from
May 14, 2024
Merged

Showcase different teal_slices in Basic teal app + update header and footer #172

merged 4 commits into from
May 14, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented May 9, 2024 •
edited
Loading

Closes #70

Changes:

  1. Basic teal app is updated to showcase all possible filter variations.
  2. Simplified the apps by removing the custom server logic for observe popup and moved it to the footer.

@vedhav vedhav added the core label May 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@vedhav vedhav force-pushed the 70-showcase-filter-options@main branch 2 times, most recently from ced2dd2 to cfefd7f Compare May 9, 2024 13:59
@vedhav vedhav force-pushed the 70-showcase-filter-options@main branch from cfefd7f to d808b3e Compare May 10, 2024 12:34
@m7pr
Copy link
Contributor

m7pr commented May 13, 2024

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor

m7pr commented May 13, 2024

recheck

@vedhav vedhav merged commit 70c081a into main May 14, 2024
1 check passed
@vedhav vedhav deleted the 70-showcase-filter-options@main branch May 14, 2024 12:29
@github-actions github-actions bot locked and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@m7pr m7pr m7pr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: New app demoing all features of filter panel
2 participants
@vedhav @m7pr