Skip to content

Commit

Permalink
Revert update to add new teal.logger shiny input changes feature (#298)
Browse files Browse the repository at this point in the history
As discussed, we will revert the changes to add shiny input changes for
teal.goshawk for now so we can move forward with release.

Related to
#297
  • Loading branch information
donyunardi authored Jul 29, 2024
1 parent edfdbba commit 3c7ef47
Show file tree
Hide file tree
Showing 10 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ Imports:
shinyvalidate,
stats,
teal.code (>= 0.4.1.9009),
teal.logger (>= 0.2.0.9004),
teal.logger (>= 0.2.0),
teal.reporter (>= 0.2.0),
teal.widgets (>= 0.4.0)
Suggests:
Expand Down
1 change: 0 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
* Adapted all modules to use `teal_data` objects.

### Enhancements
* Added `teal.logger` functionality for logging changes in shiny inputs in all modules.
* Updated the documentation and vignettes to demonstrate method to pass `teal_data` object to `teal::init()`.

### Miscellaneous
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_boxplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ srv_g_boxplot <- function(id,
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
output$axis_selections <- renderUI({
env <- shiny::isolate(as.list(data()@env))
resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_correlationplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ srv_g_correlationplot <- function(id,
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
output$axis_selections <- renderUI({
env <- shiny::isolate(as.list(data()@env))
resolved_x_param <- teal.transform::resolve_delayed(module_args$xaxis_param, env)
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_density_distribution_plot.R
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ srv_g_density_distribution_plot <- function(id, # nolint
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
output$axis_selections <- renderUI({
env <- shiny::isolate(as.list(data()@env))
resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_lineplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,6 @@ srv_lineplot <- function(id,
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
ns <- session$ns

output$axis_selections <- renderUI({
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_scatterplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,6 @@ srv_g_scatterplot <- function(id,
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
output$axis_selections <- renderUI({
env <- shiny::isolate(as.list(data()@env))
resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)
Expand Down
1 change: 0 additions & 1 deletion R/tm_g_gh_spaghettiplot.R
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,6 @@ srv_g_spaghettiplot <- function(id,
checkmate::assert_class(shiny::isolate(data()), "teal_data")

moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
output$axis_selections <- renderUI({
env <- shiny::isolate(as.list(data()@env))
resolved_x <- teal.transform::resolve_delayed(module_args$xaxis_var, env)
Expand Down
1 change: 0 additions & 1 deletion R/toggleable_slider.R
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@ toggle_slider_ui <- function(id,
# is_dichotomous_slider `logical` whether it is a dichotomous slider or normal slider
toggle_slider_server <- function(id, is_dichotomous_slider = TRUE) {
moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")
checkmate::assert_flag(is_dichotomous_slider)
# model view controller: cur_state is the model, the sliderInput and numericInputs are two views/controllers
# additionally, the module returns the cur_state, so it can be controlled from that end as well
Expand Down
2 changes: 1 addition & 1 deletion R/utils-arbitrary_lines.r
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ ui_arbitrary_lines <- function(id, line_arb, line_arb_label, line_arb_color, tit
#' @keywords internal
srv_arbitrary_lines <- function(id) {
moduleServer(id, function(input, output, session) {
teal.logger::log_shiny_input_changes(input, namespace = "teal.goshawk")

comma_sep_to_values <- function(values, wrapper_fun = trimws) {
vals <- strsplit(values, "\\s{0,},\\s{0,}")[[1]]
suppressWarnings(wrapper_fun(vals))
Expand Down

0 comments on commit 3c7ef47

Please sign in to comment.