Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update packages versions for scheduled build #292

Merged
merged 5 commits into from
Jan 21, 2025
Merged

update packages versions for scheduled build #292

merged 5 commits into from
Jan 21, 2025

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 20, 2025

@m7pr m7pr added the core label Jan 20, 2025
@m7pr
Copy link
Contributor Author

m7pr commented Jan 20, 2025

rerunning after setting up teal.slice version in extra-deps
https://github.com/insightsengineering/teal.osprey/actions/runs/12869373839

@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

Added teal.slice to Config/Needs/verdepcheck and rerunning again
https://github.com/insightsengineering/teal.osprey/actions/runs/12882703540

@m7pr m7pr marked this pull request as ready for review January 21, 2025 08:39
@m7pr m7pr requested a review from llrs-roche January 21, 2025 08:39
@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

Hey @llrs-roche I managed to satisfy 3 dependency-builds. Would you mind taking a look?

@m7pr m7pr changed the title WIP update packages versions for scheduled build update packages versions for scheduled build Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 4ba34ab.

♻️ This comment has been updated with latest results.

@llrs-roche llrs-roche self-assigned this Jan 21, 2025
@llrs-roche
Copy link
Contributor

Only failing one is "release" with:
image

Error : ! Could not solve package dependencies:
* deps::/tmp/Rtmp7hqxAt/filebf723bc2fc:
  * Can't install dependency teal (>= 0.15.2.9103) (>= 0.5.0.9021) (>= 0.5.0.9022) (>= 0.6.0.9025) (>= 0.3.0.9004) (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.transform (>= 0.5.0.9021) (>= 0.5.0.9022) (>= 0.6.0.9025) (>= 0.3.0.9004) (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.code (>= 0.5.0.9022) (>= 0.6.0.9025) (>= 0.3.0.9004) (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.data (>= 0.6.0.9025) (>= 0.3.0.9004) (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.logger (>= 0.3.0.9004) (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.reporter (>= 0.3.1.9023) (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.slice (>= 0.5.1.9021) (>= 0.4.2.9025)
  * Can't install dependency teal.widgets (>= 0.4.2.9025)

🤔 I wonder if the dependency numbers were sorted if it would make our/yours life easier. I initially thought that they were but then I realized they aren't. Something like use order(package_version(versions)) could be used.

Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, no missing or additional space and only teal.slice as extra-deps (from our packages). I wonder if teal.logger should be required with a higher version

@m7pr
Copy link
Contributor Author

m7pr commented Jan 21, 2025

@llrs-roche teal.logger is updated in DESCRIPTION.
Many 1st level dependencies are updated in DESCRIPTION.
extra-deps is for 2nd and 3rd and 4th and other level dependencies, in this case teal.slice and it's dependencies (MultiAssayExperiment and SummarizedExperiment)

@m7pr m7pr merged commit aa16fa9 into main Jan 21, 2025
29 of 30 checks passed
@m7pr m7pr deleted the fix_scheduled branch January 21, 2025 09:37
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants